Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test in comsumerTest #5846

Merged
merged 3 commits into from
Nov 16, 2020
Merged

fix flaky test in comsumerTest #5846

merged 3 commits into from
Nov 16, 2020

Conversation

zcai2
Copy link
Contributor

@zcai2 zcai2 commented Nov 15, 2020

Fixed flaky test that caused by ConsumerTest.java under skywaling-apm-datacarrier

Existing tests are flaky because the testConsumerMoreThanChannel doesn't clear channel at the beginning of this test case.

Both testConsumerLessThanChannel and testConsumerMoreThanChannel use the same carrier. In testConsumerLessThanChannel, it produces some data and store in the channel. When we run testConsumerMoreThanChannel, the data introduced by testConsumerLessThanChannel will affect this test case.

The flaky tests are found by running https://github.com/idflakies/iDFlakies

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #5846 (3502df7) into master (8325824) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5846      +/-   ##
============================================
+ Coverage     51.22%   51.27%   +0.05%     
+ Complexity     3461     3437      -24     
============================================
  Files          1654      911     -743     
  Lines         35436    22777   -12659     
  Branches       3861     2160    -1701     
============================================
- Hits          18151    11679    -6472     
+ Misses        16387    10156    -6231     
- Partials        898      942      +44     
Impacted Files Coverage Δ Complexity Δ
...g/oap/server/core/cluster/ClusterHealthStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...ng/apm/agent/core/context/trace/LogDataEntity.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...skywalking/oap/server/receiver/envoy/als/Role.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...r/receiver/envoy/als/k8s/ServiceNameFormatter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...alking/oap/server/core/cluster/OAPNodeChecker.java 0.00% <0.00%> (-93.75%) 0.00% <0.00%> (ø%)
...ent/core/context/status/ExceptionCheckContext.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (ø%)
...t/status/HierarchyMatchExceptionCheckStrategy.java 9.09% <0.00%> (-90.91%) 1.00% <0.00%> (ø%)
... and 1147 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8325824...018eeaf. Read the comment docs.

@kezhenxu94 kezhenxu94 added the test Test requirements about performance, feature or before release. label Nov 15, 2020
@kezhenxu94 kezhenxu94 merged commit 48479b7 into apache:master Nov 16, 2020
@zcai2 zcai2 deleted the flakytest branch November 25, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test requirements about performance, feature or before release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants