Support Envoy {AccessLog,Metrics}Service API V3 #5872

kezhenxu94 · 2020-11-20T17:07:12Z

Upgrade Envoy API to V3

If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes Upgrade Envoy API to V3 #5860 .
Update the CHANGES log. WILL DO BEFORE REVIEW

codecov · 2020-11-20T17:21:47Z

Codecov Report

Merging #5872 (0f859f7) into master (1b1f085) will decrease coverage by 1.32%.
The diff coverage is 4.54%.

@@             Coverage Diff              @@
##             master    #5872      +/-   ##
============================================
- Coverage     51.34%   50.02%   -1.33%     
+ Complexity     3511     3428      -83     
============================================
  Files          1693      954     -739     
  Lines         35832    23321   -12511     
  Branches       3958     2269    -1689     
============================================
- Hits          18399    11666    -6733     
+ Misses        16492    10705    -5787     
- Partials        941      950       +9

Impacted Files	Coverage Δ	Complexity Δ
...er/receiver/envoy/AccessLogServiceGRPCHandler.java	`0.00% <0.00%> (-19.24%)`	`0.00 <0.00> (-2.00)`
...erver/receiver/envoy/MetricServiceGRPCHandler.java	`0.00% <0.00%> (-12.17%)`	`0.00 <0.00> (-2.00)`
...oap/server/receiver/envoy/als/ALSHTTPAnalysis.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...server/receiver/envoy/als/AbstractALSAnalyzer.java	`0.00% <ø> (-50.00%)`	`0.00 <0.00> (ø)`
...er/receiver/envoy/als/LogEntry2MetricsAdapter.java	`0.00% <0.00%> (-50.46%)`	`0.00 <0.00> (ø)`
...g/oap/server/receiver/envoy/als/ProtoMessages.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java	`0.00% <0.00%> (-67.65%)`	`0.00 <0.00> (ø)`
...iver/envoy/als/mx/MetaExchangeALSHTTPAnalyzer.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../server/receiver/envoy/als/wrapper/Identifier.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`
.../receiver/envoy/AccessLogServiceV2GRPCHandler.java	`25.00% <25.00%> (ø)`	`1.00 <1.00> (?)`
... and 1199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b1f085...0f859f7. Read the comment docs.

wu-sheng · 2020-11-21T04:02:48Z

Seems like, there was local UT for old format? As we have the e2e, @hanahmily should we consider removing those? And Make sure e2e passed.

hanahmily · 2020-11-22T21:57:16Z

Seems like, there was local UT for old format? As we have the e2e, @hanahmily should we consider removing those? And Make sure e2e passed.

make sense to me.

kezhenxu94 · 2020-12-11T05:40:02Z

Only 1.8.0+ includes this patch to bootstrap Envoy with v3, while due to istio/istio#28956 , I think we have to wait for the latter one being cherry-picked in 1.8.x (1.8.1 doesn't include it still)

sonatype-lift · 2020-12-15T07:46:48Z

.../src/main/java/org/apache/skywalking/oap/server/receiver/envoy/MetricServiceGRPCHandler.java

+                try {
+                    double value;
+                    long timestamp = 0;
+                    switch (family.getType()) {


NULL_DEREFERENCE: object returned by family.getType() could be null and is dereferenced at line 117.

...c/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java

kezhenxu94 · 2021-01-01T12:16:24Z

Close in favor of #6116

kezhenxu94 added backend OAP backend related. dependencies Pull requests that update a dependency file labels Nov 20, 2020

kezhenxu94 force-pushed the issue/5860 branch from 32d2a88 to 331128a Compare November 21, 2020 00:44

kezhenxu94 force-pushed the issue/5860 branch from 331128a to c8d33ec Compare November 22, 2020 03:14

kezhenxu94 force-pushed the issue/5860 branch from c8d33ec to 6727985 Compare December 10, 2020 14:28

wu-sheng added this to the 8.4.0 milestone Dec 10, 2020

kezhenxu94 force-pushed the issue/5860 branch from 6727985 to 3b9fd0e Compare December 10, 2020 16:31

kezhenxu94 force-pushed the issue/5860 branch 2 times, most recently from fb1c29e to 1cf24ef Compare December 14, 2020 15:10

kezhenxu94 changed the title ~~Upgrade Envoy API to V3~~ Support Envoy {AccessLog,Metrics}Service API V3 Dec 14, 2020

kezhenxu94 force-pushed the issue/5860 branch from 1cf24ef to ac83bce Compare December 15, 2020 06:54