Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up license-eye to check license header #6200

Merged
merged 1 commit into from Jan 14, 2021

Conversation

kezhenxu94
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. NO
  • Update the CHANGES log.

@kezhenxu94 kezhenxu94 added CI settings CI settings adjustment chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. labels Jan 13, 2021
@kezhenxu94 kezhenxu94 added this to the 8.4.0 milestone Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #6200 (133e48d) into master (825a7cc) will increase coverage by 2.88%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6200      +/-   ##
============================================
+ Coverage     48.90%   51.79%   +2.88%     
- Complexity     3338     3645     +307     
============================================
  Files           928     1720     +792     
  Lines         22940    36578   +13638     
  Branches       2232     4016    +1784     
============================================
+ Hits          11218    18944    +7726     
- Misses        10773    16679    +5906     
- Partials        949      955       +6     
Impacted Files Coverage Δ Complexity Δ
...nt/kafka/provider/handler/MeterServiceHandler.java 0.00% <0.00%> (-86.67%) 0.00% <0.00%> (-6.00%)
...erver/receiver/envoy/MetricServiceGRPCHandler.java 25.92% <0.00%> (-67.41%) 3.00% <0.00%> (ø%)
.../log/provider/handler/LogReportServiceHandler.java 32.43% <0.00%> (-59.88%) 2.00% <0.00%> (ø%)
...ent/kafka/provider/handler/ProfileTaskHandler.java 26.08% <0.00%> (-47.83%) 4.00% <0.00%> (-1.00%)
...fka/provider/handler/ServiceManagementHandler.java 45.83% <0.00%> (-41.67%) 4.00% <0.00%> (-6.00%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 17.85% <0.00%> (-37.70%) 2.00% <0.00%> (ø%)
...apm/agent/core/remote/AuthenticationDecorator.java 33.33% <0.00%> (-26.67%) 3.00% <0.00%> (ø%)
...nt/kafka/provider/handler/TraceSegmentHandler.java 44.82% <0.00%> (-23.03%) 4.00% <0.00%> (-1.00%)
...ient/elasticsearch/ElasticSearchInsertRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
...ient/elasticsearch/ElasticSearchUpdateRequest.java 80.00% <0.00%> (-20.00%) 2.00% <0.00%> (ø%)
... and 1241 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825a7cc...71fd55d. Read the comment docs.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep Check License Header in one task only? It seems repeatedly check the headers.

.github/actions/e2e-test/action.yml Outdated Show resolved Hide resolved
@kezhenxu94
Copy link
Member Author

Could we keep Check License Header in one task only? It seems repeatedly check the headers.

This is intentional, it serves as a barrier to fail fast when there is file missing license header.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skywalking-ui submodule has been updated, please recheck. If this is your plan, please update the changes file.

@kezhenxu94 kezhenxu94 force-pushed the chore/license branch 4 times, most recently from ef1d5c9 to 62dd3e2 Compare January 14, 2021 08:38
@kezhenxu94
Copy link
Member Author

skywalking-ui submodule has been updated, please recheck. If this is your plan, please update the changes file.

Updated

@kezhenxu94 kezhenxu94 merged commit 98d0430 into apache:master Jan 14, 2021
@kezhenxu94 kezhenxu94 deleted the chore/license branch January 14, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. CI settings CI settings adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants