-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an agent plugin to support elasticsearch7 #6759
Conversation
# Conflicts: # CHANGES.md
# Conflicts: # apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java # apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegment.java
You missed the update of supported-list.md |
@zifeihan Please check CI |
Codecov Report
@@ Coverage Diff @@
## master #6759 +/- ##
============================================
+ Coverage 54.29% 56.92% +2.62%
+ Complexity 4194 4175 -19
============================================
Files 1801 1037 -764
Lines 38545 25785 -12760
Branches 4249 2532 -1717
============================================
- Hits 20928 14677 -6251
+ Misses 16613 9830 -6783
- Partials 1004 1278 +274 Continue to review full report at Codecov.
|
fixed. |
I just took a look and it is almost ok. Let me have a look tomorrow. :) |
Please check the CI task, you add a new plugin. |
...apache/skywalking/apm/plugin/elasticsearch/v7/define/AdapterActionFutureInstrumentation.java
Outdated
Show resolved
Hide resolved
.../apm/plugin/elasticsearch/v7/interceptor/AdapterActionFutureActionGetMethodsInterceptor.java
Outdated
Show resolved
Hide resolved
...apache/skywalking/apm/plugin/elasticsearch/v7/define/AdapterActionFutureInstrumentation.java
Outdated
Show resolved
Hide resolved
...apache/skywalking/apm/plugin/elasticsearch/v7/define/AdapterActionFutureInstrumentation.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let us wait for CI to pass.
Add an agent plugin to support elasticsearch7
Hello, I found that the current es6 plugin is not applicable to the transport-related api on es7, not only the transport api, so the es7 plugin is used to process the related logic of es7. The following exceptions may occur when using the original es6 plugin, and it will cause span not to exit normally, and threadLocal will not be cleaned up, log message such as