Support prepare and save metrics concurrency #7153

sN0wpeak · 2021-06-22T03:05:11Z

If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes Concurrent create PrepareRequest when persist Metrics #7120
Update the CHANGES log.

codecov · 2021-06-22T03:20:09Z

Codecov Report

Merging #7153 (1d9be65) into master (de1d046) will increase coverage by 4.08%.
The diff coverage is 76.31%.

❗ Current head 1d9be65 differs from pull request most recent head e453239. Consider uploading reports for the commit e453239 to get more accurate results

@@             Coverage Diff              @@
##             master    #7153      +/-   ##
============================================
+ Coverage     53.56%   57.65%   +4.08%     
+ Complexity     4294     4275      -19     
============================================
  Files          1887     1021     -866     
  Lines         40709    26243   -14466     
  Branches       4572     2605    -1967     
============================================
- Hits          21807    15130    -6677     
+ Misses        17827     9776    -8051     
- Partials       1075     1337     +262

Impacted Files	Coverage Δ
...king/oap/server/core/storage/PersistenceTimer.java	`72.17% <75.67%> (+3.60%)`	⬆️
...e/skywalking/oap/server/core/CoreModuleConfig.java	`92.50% <100.00%> (-7.50%)`	⬇️
...g/oap/server/core/cluster/ClusterHealthStatus.java	`0.00% <0.00%> (-100.00%)`	⬇️
...p/server/core/analysis/metrics/MinLongMetrics.java	`0.00% <0.00%> (-100.00%)`	⬇️
...er/exporter/provider/grpc/GRPCExporterSetting.java	`0.00% <0.00%> (-100.00%)`	⬇️
...king/oap/server/configuration/api/ConfigTable.java	`0.00% <0.00%> (-100.00%)`	⬇️
...skywalking/oap/server/receiver/envoy/als/Role.java	`0.00% <0.00%> (-100.00%)`	⬇️
...t/status/HierarchyMatchExceptionCheckStrategy.java	`9.09% <0.00%> (-90.91%)`	⬇️
...csearch/query/ProfileThreadSnapshotQueryEsDAO.java	`4.21% <0.00%> (-90.53%)`	⬇️
...ywalking/oap/server/library/util/ConnectUtils.java	`0.00% <0.00%> (-90.00%)`	⬇️
... and 1329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1d046...e453239. Read the comment docs.

wu-sheng · 2021-06-22T03:50:26Z

You should update the changelog.

...r-core/src/test/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimerTest.java

…feature/7120

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java

wu-sheng · 2021-06-22T09:02:32Z

And CIs fail, please recheck.

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java

…/server/core/storage/PersistenceTimer.java Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>

...ver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/BlockingBatchQueue.java

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java

inAppendingMode

wu-sheng

LGTM. @dmsolr @EvanLjp Please check codes, more feedback is welcome.

EvanLjp

LGTM, It's more clear than before.

wu-sheng · 2021-06-27T01:58:09Z

@a1vin-tian Before merge, could you run this latest codes on prod or test env, let's see how self observability looks like.

sN0wpeak · 2021-06-28T07:56:22Z

@a1vin-tian Before merge, could you run this latest codes on prod or test env, let's see how self observability looks like.

Okay, I will do it these two days.

sN0wpeak · 2021-06-29T06:31:43Z

@wu-sheng

After:

Befor:

as time goes on.

wu-sheng · 2021-06-29T06:34:10Z

@a1vin-tian Thank you so much for your good polish, patient, and keeping testing in real env. I am going to merge this.

…alking into id-read-optimization * 'id-read-optimization' of https://github.com/apache/skywalking: Support prepare and save metrics concurrency (#7153) Update MetricsPersistentWorker.java # Conflicts: # oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java

… and concurrency process

… and concurrency process (#7318) The key logic behinds all these is, metrics persistence is fully asynchronous. * The core/maxSyncOperationNum setting(added in 8.5.0) is removed due to metrics persistence is fully asynchronous. * The core/syncThreads setting(added in 8.5.0) is removed due to metrics persistence is fully asynchronous. * Optimization: Concurrency mode of execution stage for metrics is removed(added in 8.5.0). The only concurrency of prepare stage is meaningful and kept. * Remove the outside preparedRequest list initialization, worker instance could always build a suitable size list in the first place (Reduce Array.copy and GC load a little).

init commit

214da03

wu-sheng requested review from EvanLjp, wu-sheng, dmsolr and kezhenxu94 June 22, 2021 03:50

wu-sheng added this to the 8.7.0 milestone Jun 22, 2021

wu-sheng added backend OAP backend related. enhancement Enhancement on performance or codes labels Jun 22, 2021

田雪峰 added 2 commits June 22, 2021 11:58

update change log

2addcfa

add testcase

f6aafc7

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...r-core/src/test/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimerTest.java Outdated Show resolved Hide resolved

田雪峰 and others added 5 commits June 22, 2021 15:58

sync test

b906892

Merge branch 'master' into feature/7120

1d7a64d

delete unused import

f260cff

Merge branch 'feature/7120' of github.com:a1vin-tian/skywalking into …

2424850

…feature/7120

verify there are same elements between result and mockdata.

4e65f8b

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

delete unuse

8c20abd

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 22, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

田雪峰 added 2 commits June 22, 2021 17:03

use one sync

5c973db

delete unuse code

cf83ec7

kezhenxu94 reviewed Jun 22, 2021

View reviewed changes

Update oap-server/server-core/src/main/java/org/apache/skywalking/oap…

760fd37

…/server/core/storage/PersistenceTimer.java Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>

田雪峰 added 4 commits June 24, 2021 18:52

format code

d0b32d0

corract code

1630722

add License

fbd76d8

add result

b237306

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...ver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/BlockingBatchQueue.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng added 2 commits June 24, 2021 21:06

Update PersistenceTimer.java

4d6bfc0

Update BlockingBatchQueue.java

128e8e1

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Outdated Show resolved Hide resolved

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Show resolved Hide resolved

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Show resolved Hide resolved

wu-sheng reviewed Jun 24, 2021

View reviewed changes

...erver-core/src/main/java/org/apache/skywalking/oap/server/core/storage/PersistenceTimer.java Show resolved Hide resolved

田雪峰 and others added 4 commits June 25, 2021 11:09

update inital capacity in array list and add expcetion when offer with

d5a315a

inAppendingMode

use for test

4c954fd

Merge branch 'master' into feature/7120

34c9031

WRITEBOX test

a44222b

wu-sheng requested a review from kezhenxu94 June 26, 2021 15:28

wu-sheng approved these changes Jun 26, 2021

View reviewed changes

EvanLjp approved these changes Jun 27, 2021

View reviewed changes

Merge branch 'master' into feature/7120

e453239

wu-sheng merged commit a966eea into apache:master Jun 29, 2021

wu-sheng mentioned this pull request Jun 30, 2021

Fix the queue initial size is not set by max batch size accordingly #7204

Merged

2 tasks

wu-sheng added a commit that referenced this pull request Jul 16, 2021

Logically revert #6642 and partial #7153 to reduce unnecessary thread…

0c047ce

… and concurrency process

wu-sheng mentioned this pull request Jul 16, 2021

Logically revert #6642 and partial #7153 to reduce unnecessary thread and concurrency process #7318

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support prepare and save metrics concurrency #7153

Support prepare and save metrics concurrency #7153

sN0wpeak commented Jun 22, 2021 •

edited by kezhenxu94

codecov bot commented Jun 22, 2021 •

edited

wu-sheng commented Jun 22, 2021

wu-sheng commented Jun 22, 2021

wu-sheng left a comment

EvanLjp left a comment

wu-sheng commented Jun 27, 2021

sN0wpeak commented Jun 28, 2021

sN0wpeak commented Jun 29, 2021

wu-sheng commented Jun 29, 2021

Support prepare and save metrics concurrency #7153

Support prepare and save metrics concurrency #7153

Conversation

sN0wpeak commented Jun 22, 2021 • edited by kezhenxu94

codecov bot commented Jun 22, 2021 • edited

Codecov Report

wu-sheng commented Jun 22, 2021

wu-sheng commented Jun 22, 2021

wu-sheng left a comment

Choose a reason for hiding this comment

EvanLjp left a comment

Choose a reason for hiding this comment

wu-sheng commented Jun 27, 2021

sN0wpeak commented Jun 28, 2021

sN0wpeak commented Jun 29, 2021

wu-sheng commented Jun 29, 2021

sN0wpeak commented Jun 22, 2021 •

edited by kezhenxu94

codecov bot commented Jun 22, 2021 •

edited