Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collector service instrumentation #730

Merged
merged 14 commits into from
Apr 1, 2018

Conversation

wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Jan 5, 2018

In order to help the collector performance test, I add a collector agent.

  • Instrument all collector service.
  • Collect metrics: success rate, calls and avg response time
  • Output all metrics to log in Warn level

FYI @ascrutae , collector startup script need an argument (named -instrument) to make this agent works.

@wu-sheng wu-sheng added this to the 5.0.0-alpha milestone Jan 5, 2018
ascrutae
ascrutae previously approved these changes Jan 5, 2018
Copy link
Member

@ascrutae ascrutae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling 45410f5 on collector/instrument into af2c1b9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling 45410f5 on collector/instrument into af2c1b9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling 59dca4b on collector/instrument into af2c1b9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling 6378128 on collector/instrument into af2c1b9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling f13d63a on collector/instrument into af2c1b9 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.342% when pulling 21ed217 on collector/instrument into af2c1b9 on master.

@wu-sheng
Copy link
Member Author

  • Output with metric
##################################################################################################################
#                                             Collector Service Report                                           #
##################################################################################################################
/segment/parse
	Avg=10380668 (nano), Success Rate=100%, Calls=14
/segment/parse/preBuild
	Avg=5139819 (nano), Success Rate=100%, Calls=14
/segment/parse/buildSegment
	Avg=25482 (nano), Success Rate=100%, Calls=14
/worker/async/consume/ApplicationMapping/ApplicationMapping
	Avg=7036928 (nano), Success Rate=100%, Calls=1 Rows per call = 1
/worker/async/consume/Segment/Segment
	Avg=358379 (nano), Success Rate=100%, Calls=316 Rows per call = 2
/worker/async/consume/ServiceEntry/ServiceEntry
	Avg=2938083 (nano), Success Rate=100%, Calls=1 Rows per call = 1
/worker/async/consume/ServiceReferenceMetric/ServiceReferenceMetric
	Avg=5497347 (nano), Success Rate=100%, Calls=1 Rows per call = 3
/worker/async/consume/ApplicationComponent/ApplicationComponent
	Avg=5471366 (nano), Success Rate=100%, Calls=1 Rows per call = 3
/worker/async/consume/GlobalTrace/GlobalTrace
	Avg=72356 (nano), Success Rate=100%, Calls=1 Rows per call = 2
/worker/async/consume/InstanceMapping/InstanceMapping
	Avg=3810820 (nano), Success Rate=100%, Calls=1 Rows per call = 1
  • Output in waiting
##################################################################################################################
#                                             Collector Service Report                                           #
##################################################################################################################
/segment/parse
	Avg=N/A
/segment/parse/preBuild
	Avg=N/A
/segment/parse/buildSegment
	Avg=N/A
/worker/async/consume/ApplicationMapping/ApplicationMapping
	Avg=N/A
/worker/async/consume/Segment/Segment
	Avg=N/A
/worker/async/consume/ServiceEntry/ServiceEntry
	Avg=N/A
/worker/async/consume/ServiceReferenceMetric/ServiceReferenceMetric
	Avg=N/A
/worker/async/consume/ApplicationComponent/ApplicationComponent
	Avg=N/A
/worker/async/consume/GlobalTrace/GlobalTrace
	Avg=N/A
/worker/async/consume/InstanceMapping/InstanceMapping
	Avg=N/A

@wu-sheng
Copy link
Member Author

@peng-yongsheng @ascrutae All codes are done. @ascrutae please adjust the startup shell and bat.

@coveralls
Copy link

coveralls commented Jan 10, 2018

Coverage Status

Coverage remained the same at 19.392% when pulling 3d86e04 on collector/instrument into 4390d8f on master.

@wu-sheng wu-sheng removed this from the 5.0.0-alpha milestone Mar 5, 2018
@wu-sheng
Copy link
Member Author

wu-sheng commented Mar 5, 2018

Waiting for performance test begin.

@peng-yongsheng peng-yongsheng merged commit 049dc2f into master Apr 1, 2018
@peng-yongsheng peng-yongsheng deleted the collector/instrument branch April 1, 2018 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants