SLING-7605 - ContentDeploymentTest sometimes fails on Jenkins #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Sling 11 for ITs in hopes of increasing the success rate. - use the slingstart-maven-plugin - use preemptive authentication for the ExternalSlingLaunchpad ready check - for the nodes reordering tests use an node type that is actually ordered to make sure the assertions are relevant. - check for the JCR repository being available in ExternalSlingLaunchpad
rombert
force-pushed
the
feature/SLING-7605
branch
from
da3891b
to
c3466a8
Compare
- adjust test to possibility of having multiple events delivered and document it. - race condition when shutting down the DirWatcher: when the poller thread is interrupted and then the watch service is closed the polling may be running and the interrupt may be acted on too late. Treat this as a regular occurence and simply stop polling.
rombert
force-pushed
the
feature/SLING-7605
branch
from
6fea6de
to
3aec78d
Compare
- update to a more recent Orbit ( Oxygen baseline ) - pull in slf4j-simple and slf4j-log4j where needed - update ExternalSlingLaunchpad to use slf4j apis
Enable debug profile when running Eclipse tests on Jenkins
rombert
force-pushed
the
feature/SLING-7605
branch
from
3aec78d
to
fd569e9
Compare
|
While the ITs are still not stable, they have improved and I think it's worthwhile to merge these changes and follow-up with more fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to Sling 11 for ITs in hopes of increasing the success rate.
sure the assertions are relevant.