Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-11524 Always retrieve bundle file from project's artifacts #8

Merged
merged 2 commits into from
Aug 11, 2022
Merged

SLING-11524 Always retrieve bundle file from project's artifacts #8

merged 2 commits into from
Aug 11, 2022

Conversation

kwin
Copy link
Member

@kwin kwin commented Aug 11, 2022

No description provided.

@kwin kwin changed the title SLING-11524 Always retrieve bundle file from project artifact's SLING-11524 Always retrieve bundle file from project's artifacts Aug 11, 2022
@kwin kwin force-pushed the feature/use-attached-artifacts branch from 14e2c8c to cb5a87a Compare August 11, 2022 14:20
rombert
rombert reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I wonder if we have users that deploy arbitrary bundles from the filesystem which will be broken by this change.

@kwin
Copy link
Member Author

kwin commented Aug 11, 2022

if we have users that deploy arbitrary bundles from the filesystem which will be broken by this change.

This is still supported with the correct goal install-file: https://sling.apache.org/components/sling-maven-plugin/install-file-mojo.html
The install goal was IMHO never intended for deploying arbitrary files.

@rombert
Copy link
Contributor

rombert commented Aug 11, 2022

This is still supported with the correct goal install-file: https://sling.apache.org/components/sling-maven-plugin/install-file-mojo.html

Ah, I misread, sorry.

@kwin kwin merged commit 6af8d68 into master Aug 11, 2022
@kwin kwin deleted the feature/use-attached-artifacts branch August 11, 2022 15:21
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rombert rombert rombert approved these changes

@stefanseifert stefanseifert Awaiting requested review from stefanseifert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kwin @rombert