Strings and Boxed types should be compared using "equals()" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 1 Sonarqube violation of rule S4973: https://rules.sonarsource.com/java/RSPEC-4973 Sonarcloud violation URL: https://sonarcloud.io/organizations/apache/issues?languages=java&open=AWogePnQ9zLXaOU8uV59&resolved=false&rules=squid%3AS4973&types=BUG Jira Ticket: https://issues.apache.org/jira/browse/SLING-8825
HarisAdzemovic
added a commit
to ASSERT-KTH/sorald
that referenced
this pull request
Nov 6, 2019
Link to PR: apache/sling-org-apache-sling-auth-core#1 Link to Jira ticket: https://issues.apache.org/jira/browse/SLING-8825 Sniper mode only added a single whitespace which was removed manually before making the pull request.
|
Thanks for the PR - the current code looks strange, however with the suggest PR a NPE might occur as sudo might be null. The current boolean is taking this into account. I think a much better way would be to remove that boolean and the setCookie check and adjust the following if blocks |
|
SonarCloud Quality Gate failed. |
|
Closing in favour of https://issues.apache.org/jira/browse/SLING-10319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 1 Sonarqube violation of rule S4973:
https://rules.sonarsource.com/java/RSPEC-4973
Sonarcloud violation URL:
https://sonarcloud.io/organizations/apache/issues?languages=java&open=AWogePnQ9zLXaOU8uV59&resolved=false&rules=squid%3AS4973&types=BUG
Jira Ticket:
https://issues.apache.org/jira/browse/SLING-8825