SLING-11114 Use a LazySupplier for the caconfig binding #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
stefanseifert
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
lgtm, thanks
the integration tests do no longer run with this change, though:
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests
the are using the latest release sling 11 version which is still on Sling API 2.18.4.
i think it makes sense to update to Sling API 2.21.0 if this is the minimum version that provides LazyBindings - but we should then update the integration tests as well.
|
Thanks @stefanseifert, I will take care of that. |
|
Kudos, SonarCloud Quality Gate passed! |
1 similar comment
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the LazyBinding we can avoid to perform checks and validations when the binding is not used.
As a side effect I had to update to Sling API 2.21.0