SLING-9153 - MIME Type detection leaks temporary files when given a ZIP file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Feb 26, 2020
| MediaType mediaType = detector.detect(stream, metadata); | ||
| MediaType mediaType; | ||
| TemporaryResources tmp = new TemporaryResources(); | ||
| try { |
There was a problem hiding this comment.
Please use https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html instead! BTW no need to close the PR, you can just add commits or force push to the existing branch!
There was a problem hiding this comment.
ok, so I will put it like this
try (TemporaryResources tmp = new TemporaryResources()){ ...}
and remove the finally block
Is it fine?
kwin
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLING-9153 - MIME Type detection leaks temporary files when given a ZIP file