Strings and Boxed types should be compared using "equals()"

[HarisAdzemovic]

This fixes 1 Sonarqube violation of rule S4973:
https://rules.sonarsource.com/java/RSPEC-4973

Sonarcloud violation URL:
https://sonarcloud.io/organizations/apache/issues?open=AWpM6AUjyRjJygCrlORM&resolved=false&rules=squid%3AS4973

Jira ticket:
https://issues.apache.org/jira/browse/SLING-8825

[rombert]

Thanks for the PR @HarisAdzemovic! Changes LGTM.

@stefan-egli - WDYT?

[stefan-egli]

+1, lgtm
for the record: this doesn't fix a bug but makes the code more explicit and compliant

[HarisAdzemovic]

Thank you, @rombert and @stefan-egli!
There are a number of these occurrences across several Sling components according to Sonarcloud. Are you fine with me making PRs to those as well? I'm asking since it'll be a number of very similar PRs and I don't want to be seen as just "spamming" them without direction.

[rombert]

@HarisAdzemovic - absolutely, PRs are welcome. I would only suggest doing one PR per git repo as opposed to one PR per problem or PR per problem type, just to make things manageable.

[HarisAdzemovic]

Great! Thanks for the tips!