Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-9389: Distribution Event Packages should contain queue item creation time #41

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SLING-9389: Distribution Event Packages should contain queue item creation time #41

wants to merge 4 commits into from

Conversation

harshchiki
Copy link

  • Improvement aims at adding the queue item creation time, essentially when the the item was creation for the first time, and enqueue into the queue.
  • The purpose to get this detail is to be able to capture metrics at the consumer level. The consumers could have an event handler, which can capture the duration which turns out to be (NOW MINUS queue item creation time thrown in the distribution event package); NOW being the current time in the event handler (consumer).

@harshchiki harshchiki mentioned this pull request Apr 30, 2020
Closed
@harshchiki
Copy link
Author

SCD API PR - apache/sling-org-apache-sling-distribution-api#2

@harshchiki
Copy link
Author

harshchiki commented May 27, 2020 •
edited
Loading

This PR is failing on the missing DistributionEventProperties.DISTRIBUTION_ENQUEUE_TIMESTAMP(compilation error), which is proposed in apache/sling-org-apache-sling-distribution-api#7 - IIUC, once that is merged, this should pass fine.

Request the owners of the repo to kindly review.

cc: @tmaret @cschneider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actinium15 actinium15 actinium15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harshchiki @actinium15