SLING-8620 - Journal Distribution discovery service should log topolo… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gy changes at INFO level
cschneider
requested changes
Aug 8, 2019
|
The build fails as the release is not yet public. How about using the current snapshot until then? |
…gy changes at INFO level * use static import for String.format
Sure, good point. Done in next commit. |
|
Regarding the snapshot, I'd prefer if we wait for the release. We should update the dependencies when it's required and not for process reason. |
…gy changes at INFO level
|
Moved to #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gy changes at INFO level