Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-11928 improve log message, improve name of some constants #133

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

joerghoh
Copy link
Contributor

@joerghoh joerghoh commented Jan 5, 2024

No description provided.

@joerghoh joerghoh changed the title improve log message, improve name of some constants SLING-11928 improve log message, improve name of some constants Jan 5, 2024
Copy link
Contributor

@cschneider cschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the constants I would either use _MS or _MILLIS.
I personally prefer _MS as most people sill understand and it is shorter.
Apart from that it looks good.

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
58.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joerghoh joerghoh merged commit 8aa3408 into master Feb 9, 2024
@joerghoh joerghoh deleted the SLING-11928-improve-log-message branch February 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants