add Forward filter scope to CacheControlFilter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvangeem
force-pushed
the
synthetic-forward-filter-fix
branch
from
d995f4c
to
5a8bbff
Compare
ericvangeem
changed the title
|
This is quite a significant issue for synthetic resource caching, any chance we can proceed with a merge and release? |
|
Sorry for taking so long to merge, and thanks for the contribution @ericvangeem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CacheControlFilter servlet is missing the
SlingFilterScope.FORWARDscope which is needed to receive the forced resourceType set by the SyntheticResourceFilter for synthetic resources.JIRA ticket has been created here: https://issues.apache.org/jira/browse/SLING-8427