SLING-12297 log a warning in case no servlet was found #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -517,6 +518,11 @@ public static void service(SlingHttpServletRequest request, | |||
| Servlet servlet = requestData.getContentData().getServlet(); | |||
| if (servlet == null) { | |||
|
|
|||
| log.warn("Did not find a servlet to handle the request (path=%s,selectors=%,extension=%s,suffix=%s)", | |||
There was a problem hiding this comment.
A couple things:
- Shouldn't these just be positional parameters (
{}) in logs, notString.format-style parameters? - Not sure if needed here, but if you use a logger method that ends up var-args (more than 2 format arguments/exception), it is often good to wrap with
if (Logger.isXxxEnabled()) { ... }to avoid the varargs array creation.
For (2) it really depends on how frequently it is expected to occur. This one might be ok, but I figured better to mention it.
There was a problem hiding this comment.
I don't expect that this code path is taken very frequently, as it's in a error path, which results in a 404.
But are so right about (1)
Fix in #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.