Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-11923 : fixed IT failures for JDK 17 #32

Merged
merged 5 commits into from Jul 18, 2023

Conversation

rishabhdaim
Copy link
Contributor

No description provided.

@rishabhdaim
Copy link
Contributor Author

@stefan-egli could you please review the PR

@rombert rombert requested a review from stefan-egli July 13, 2023 14:19
@stefan-egli
Copy link
Contributor

(reran the tests to see if it was a flaky failure)

@rishabhdaim
Copy link
Contributor Author

@stefan-egli @rombert we need to update https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690 wiki as well for org.apache.sling.testing.paxexam update

@stefan-egli
Copy link
Contributor

@rishabhdaim

  • good point about updating the wiki. Something along the lines of "paxexam 4.0 is required for Java 17" ?
  • .java-version : noticed you added this file, do we need this?
SLING-11923 : removed jacoco while using pax exam 4

I'll ignore the test failures prior to run 6 then. Run 6 itself had a test fialure with InitDelayingTopologyEventListenerTest.testProperties, so perhaps that's an actual flaky test. I'd like to do some more test rounds to get a better understanding.

@stefan-egli
Copy link
Contributor

@rishabhdaim , looks like it might not be a flaky test so much anymore - but maybe it's just a very slow piece of hardware used - could you please increase the sleep(5000) here in your fork to eg sleep(10000) - just to check? thx!

@rishabhdaim
Copy link
Contributor Author

@stefan-egli

  • I have updated the sleep(5000) to sleep(10000) in my fork.
  • .java-version: was added accidentally, will remove it.

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@stefan-egli stefan-egli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, nice, now the tests run through. I'll go ahead and merge.

@stefan-egli stefan-egli merged commit 9a244f8 into apache:master Jul 18, 2023
3 checks passed
@rishabhdaim rishabhdaim deleted the SLING-11923 branch July 19, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants