Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-10786 : DefaultAclManager - sonar finding #110

Merged
merged 1 commit into from Sep 2, 2021
Merged

SLING-10786 : DefaultAclManager - sonar finding #110

merged 1 commit into from Sep 2, 2021

Conversation

anchela
Copy link
Contributor

@anchela anchela commented Sep 2, 2021

@karlpauls , i would appreciate if you had time to take a look. after refactoring the method getCreatePath to reduce it's complexity it struck me that the separate if for RepoPath.getParent being null is only executed at the very end. imho that should go first as computing the "CreatePath" statement doesn't impact the original RepoPath param, does it?

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

karlpauls
karlpauls approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@karlpauls karlpauls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anchela, I don't see how it could be impacted either. Looks good to me.

@anchela anchela merged commit 48a7fa6 into master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlpauls karlpauls karlpauls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@anchela @karlpauls