Feature Converter doesn't cleanup after itself

[kaushalmall]

added cleanup method to cleanup directories that the converter create.

FYI @DominikSuess

[DominikSuess]

Despite of the suggestions of @bosschaert I think this PR is improving the situation - we could think of improving it to properly clean up after itself as well but for the issue at hand cleaning the working directories sounds like a good plan.

[cziegeler]

I assume the problem here is a re-run of the tool?
If that is the case, why not delete the directory before running the tool; this way someone just running the tool once does not pay the price of waiting for the directory delete

It would also be good to have a jira issue for this

[bdelacretaz]

FWIW, I think "synthetic" is spelled wrong in syntethic-content-packages - but maybe that's a reflection of a typo made elsewhere.

[kaushalmall]

Hi @cziegeler @DominikSuess if this is preferred, I can move this code to the corresponding class(es) to delete before the processing starts. Let me know.

why not delete the directory before running the tool;

@DominikSuess do you mind creating an issue for this? Not sure if I have access

It would also be good to have a jira issue for this

Please add that the "synthetic" typo is also fixed as part of this issue :-)

[kaushalmall]

@bdelacretaz thanks for catching it, the original class has the same typo, but, I just updated the PR to fix it across the board.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

8.3% Coverage
0.0% Duplication

The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

[bosschaert]

do you mind creating an issue for this? Not sure if I have access

Creating a sling issue can be done by anyone. Just create an account and file the issue here: https://issues.apache.org/jira/projects/SLING

[kaushalmall]

created https://issues.apache.org/jira/browse/SLING-9490
thanks @bosschaert

[kaushalmall]

hi @DominikSuess @cziegeler @bdelacretaz @bosschaert any reason for this to not be merged?

[cziegeler]

@kaushalmall Sorry, it's applied now - thanks!