Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-12028 - Content Deployment Extension tests fail on Windows #19

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

rombert
Copy link
Contributor

@rombert rombert commented Sep 19, 2023

No description provided.

Use a File.separator instead of hardcoding '/' . The assumption of the content extension is that
generated plans will pe processed on the same operating system, so we don't care too much about now
about cross-platform compatiblity, i.e. run the extension on Windows and then deploy on Linux.
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rombert rombert merged commit 9c4d4f0 into master Sep 19, 2023
3 checks passed
@rombert rombert deleted the issue/SLING-12028 branch September 19, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant