Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-12029 - Make strictMode configurable #20

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

rombert
Copy link
Contributor

@rombert rombert commented Sep 20, 2023

Make strictMode configurable and document the way to configure it.

Make strictMode configurable and document the way to configure it.
@rombert rombert requested a review from kwin September 20, 2023 09:10
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rombert
Copy link
Contributor Author

rombert commented Sep 20, 2023

SonarCloud Quality Gate failed. Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell B 1 Code Smell

100.0% 100.0% Coverage 0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

The code smell is an existing issue and IMO unimportant (use dedicated exception). Will ignore.

@rombert rombert merged commit 71798cc into master Sep 20, 2023
2 of 3 checks passed
@rombert rombert deleted the issue/SLING-12029 branch September 20, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant