Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-12232 : Switch to httpclient 4.x #5

Merged
merged 3 commits into from
Jan 19, 2024
Merged

SLING-12232 : Switch to httpclient 4.x #5

merged 3 commits into from
Jan 19, 2024

Conversation

cziegeler
Copy link
Contributor

No description provided.

@kwin
Copy link
Member

kwin commented Jan 19, 2024

Isn’t it time for switching to JRE Http Client (and require Java11)?

@cziegeler
Copy link
Contributor Author

I don't care that much which we use, however I don't see retry handling in java httpclient

bosschaert
bosschaert approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@bosschaert bosschaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

73.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@cziegeler
Copy link
Contributor Author

Thanks @bosschaert

@cziegeler cziegeler merged commit f316fa5 into master Jan 19, 2024
1 check passed
@cziegeler cziegeler deleted the SLING-12232 branch January 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosschaert bosschaert bosschaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cziegeler @kwin @bosschaert