SLING-11408 m-assembly-p must use dependencies generated from

[kwin]

appassembler

[cziegeler]

Thanks, this makes the launcher now start, but all logs from the launcher are now gone, so I guess there is something wrong with slf4j dependencies

[cziegeler]

ok, so additional problems:

1. slf4j-impl is missing
2. the launch script now lists all jar files from libs as the classpath, whereas previously a wildcard was used, which allowed to just add new jars in the libs directory

[kwin]

Probably

sling-org-apache-sling-feature-launcher/pom.xml

Line 259 in 072fe2a

<scope>provided</scope>

needs to have compile or runtime scope. Appassembler by default only considers Maven runtime scope.

[cziegeler]

I fixed the two issues

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[kwin]

I would rather have this scope runtime, as definitely not needed in the compile class path.

[cziegeler]

Feel free to adjust if it is still working then

[kwin]

Done in b55ca9c.