Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-9860 When merging artifacts with the ALL strategy, incorrect feature-origin metadata is recorded #22

Merged
merged 1 commit into from Oct 29, 2020

Conversation

bosschaert
Copy link
Contributor

When merging with the ALL strategy, don't add the feature-origins from the
source feature to the existing artifacts in the target feature.

…ature-origin metadata is recorded

When merging with the ALL strategy, don't add the feature-origins from the
source feature to the existing artifacts in the target feature.
@bosschaert bosschaert requested review from cziegeler and karlpauls and removed request for cziegeler October 29, 2020 11:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

Copy link
Contributor

@cziegeler cziegeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@bosschaert bosschaert merged commit 7d7bf8a into apache:master Oct 29, 2020
Copy link
Contributor

@karlpauls karlpauls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants