Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-11211: updated maven dependencies && fixed broken links #2

Merged
merged 5 commits into from Mar 18, 2022
Merged

SLING-11211: updated maven dependencies && fixed broken links #2

merged 5 commits into from Mar 18, 2022

Conversation

apelluru
Copy link
Member

  • Updated sling parent bundle to version 46
  • Updated maven dependencies for junit4
  • Fixed broken links in README.md

enapps-enorman
enapps-enorman reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@enapps-enorman enapps-enorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some review comments to request clarification on some of the dependency versions changes.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
klcodanr
klcodanr requested changes Mar 17, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@apelluru apelluru changed the title SLING-11211: updated maven dependencies && fixed broken links from Re… SLING-11211: updated maven dependencies && fixed broken links Mar 17, 2022
@apelluru
Update pom.xml
8e7e576 
GitHub PR is not showing commits
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

enapps-enorman
enapps-enorman approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@enapps-enorman enapps-enorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. The new manifest looks compatible with the last release.

klcodanr
klcodanr approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@klcodanr klcodanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@apelluru
Copy link
Member Author

Hi @enapps-enorman or @klcodanr who will merge this pull request?

@klcodanr klcodanr merged commit d028263 into apache:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klcodanr klcodanr klcodanr approved these changes

@enapps-enorman enapps-enorman enapps-enorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@apelluru @klcodanr @enapps-enorman