Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLING-11595 Add missing test case for AnnotationConflictsTest #38

Merged
merged 1 commit into from Mar 28, 2023
Merged

SLING-11595 Add missing test case for AnnotationConflictsTest #38

merged 1 commit into from Mar 28, 2023

Conversation

karollewandowski
Copy link
Contributor

This test if similar to FailingSingleRequiredBySeparateAnnotationOverridingStrategyFieldModel but it tests the opposite case: @Optional overrides injectionStrategy = REQUIRED.

See also:

joerghoh
joerghoh approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@joerghoh joerghoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanseifert stefanseifert changed the title Add missing test case for AnnotationConflictsTest SLING-11595 Add missing test case for AnnotationConflictsTest Mar 28, 2023
@stefanseifert stefanseifert merged commit 2d0f287 into apache:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerghoh joerghoh joerghoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@karollewandowski @joerghoh @stefanseifert