Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-12285 adding bind & unbind methods mapping #3

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

gagan031992
Copy link
Contributor

Adding bind & unbind methods mapping in reference annotation.
Currently Binding & Unbinding of methods are not working after moving on OSGI R6 annotation.

@rombert
Copy link
Contributor

rombert commented Apr 10, 2024

@gagan031992 - thanks for the PR! Since this is a non-trivial change, can you please open a Jira issue?

https://issues.apache.org/jira/browse/SLING

@gagan031992 gagan031992 changed the title adding bind & unbind methods mapping SLING-12285 adding bind & unbind methods mapping Apr 10, 2024
@gagan031992
Copy link
Contributor Author

Hello @rombert ,

Here is the Sling issue for it.
https://issues.apache.org/jira/browse/SLING-12285

@rombert
Copy link
Contributor

rombert commented Apr 10, 2024

Thanks @gagan031992 ! I asked for clarification there.

Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rombert rombert merged commit c0ea19a into apache:master Apr 11, 2024
2 checks passed
@rombert
Copy link
Contributor

rombert commented Apr 11, 2024

Thanks for the PR and explanation in the Jira issue @gagan031992 , I've merged the fix and will create a release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants