SLING-12265 - Improve node type registration in JCR_OAK #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csaboka
force-pushed
the
SLING-12265
branch
2 times, most recently
from
1f13653
to
20b39e9
Compare
csaboka
changed the title
Instead of calling CndImporter (and triggering one commit per CND file), parse each CND file separately and register them all at once. This doesn't just reduce the number of commits, but also takes care of inter-type dependencies.
stefanseifert
requested changes
Apr 9, 2024
There was a problem hiding this comment.
thanks @csaboka for this contribution, this looks very good! i've run some unit tests locally with this PR, and there is really a considerable improvement if JCR_OAK is used.
please check my review comment.
core/src/main/java/org/apache/sling/testing/mock/sling/NodeTypeDefinitionScanner.java
Outdated
Show resolved
Hide resolved
Turns out Oak already does this for us on commit, so there is no need for duplicating the code. The Mock JCR implementation doesn't, but we won't try to register node types for it in the first place.
|
stefanseifert
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling CndImporter (and triggering one commit per CND file), parse each CND file separately and register them all at once. This doesn't just reduce the number of commits, but also takes care of inter-type dependencies.