Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLING-9886 convert ITs post-execution script from Beanshell to Groovy #60

Merged
merged 1 commit into from Nov 10, 2020

Conversation

kwin
Copy link
Member

@kwin kwin commented Nov 9, 2020

Only the array initializers were converted from Java to Groovy style,
the rest was left untouched.

The changes exposes some actual IT failures

Only the array initializers were converted from Java to Groovy style,
the rest was left untouched.

The changes exposes some actual IT failures
@cziegeler
Copy link
Contributor

Changes look ok to me - if the project still builds with Java 8 and Java 11 afterwards, +1

@kwin
Copy link
Member Author

kwin commented Nov 10, 2020

Someone needs to fix the failing ITs. I don't know if those are actual bugs in the code or just flaws in the IT.

@cziegeler
Copy link
Contributor

How many ITs are failing after the change?

@kwin
Copy link
Member Author

kwin commented Nov 10, 2020

[ERROR] The following builds failed:
[ERROR] *  apis-jar-wrapped-flattened-classes/pom.xml
[ERROR] *  apis-jar-wrapper-bundle/pom.xml
[ERROR] *  apis-jar/pom.xml

(https://ci-builds.apache.org/job/Sling/job/modules/job/sling-slingfeature-maven-plugin/job/PR-60/1/console)

@cziegeler
Copy link
Contributor

Sounds doable, I think it makes sense to create a new issue to fix the ITs

@kwin
Copy link
Member Author

kwin commented Nov 10, 2020

So should I go ahead and merge and break the Jenkins build of master?

@cziegeler
Copy link
Contributor

Yes and please create a new issue for the ITs - I'll try to look into that one then

@kwin kwin merged commit a5439d4 into master Nov 10, 2020
@kwin kwin deleted the feature/it-verify-with-groovy branch November 10, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants