Remove Etcd support from the Solr Operator #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
changed the title
HoustonPutman
added a commit
to HoustonPutman/solr-operator
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Houston Putman <hputman@apple.com>
HoustonPutman
force-pushed
the
remove-etcd
branch
from
6addf74
to
443b1cc
Compare
HoustonPutman
added a commit
to HoustonPutman/solr-operator
that referenced
this pull request
Oct 28, 2020
Signed-off-by: Houston Putman <hputman@apple.com>
HoustonPutman
force-pushed
the
remove-etcd
branch
from
443b1cc
to
0c09466
Compare
Signed-off-by: Houston Putman <hputman@apple.com>
HoustonPutman
force-pushed
the
remove-etcd
branch
from
0c09466
to
352b774
Compare
|
This is good to go @bsankara. Will be awesome to get this code out of the operator. |
bsankara
approved these changes
Nov 5, 2020
dalbani
reviewed
Nov 5, 2020
| @@ -19,7 +19,7 @@ Please follow the instructions from the [local tutorial](local_tutorial.md#setup | |||
|
|
|||
| ### Install the necessary dependencies | |||
|
|
|||
| Install the Zookeeper & Etcd Operators, which this operator depends on by default. | |||
There was a problem hiding this comment.
@HoustonPutman
I suppose you didn't want to remove the word "Operators".
There was a problem hiding this comment.
Oops, good call there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: Resolves #117
Describe your changes
Removed all config options for using Solr with Zetcd.
I have also moved around the Provided zookeeper section as it doesn't make a large amount of sense if the zetcd option is gone.
Testing performed
Testing is done to make sure that the new options work correctly and that the migration of options also works.