Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding pod resources tuning options, adding imagepullsecert to promexporter #35

Conversation

sepulworld
Copy link
Contributor

@sepulworld sepulworld commented Oct 15, 2019

Signed-off-by: Zane Williamson zanew@zillow.com

*Issue number of the reported bug or feature request: #34

Describe your changes
Added ImagePullSecrets and Pod Resource options to Deployment for PrometheusExporter
Added Pod Resource options to StatefulSet generation SolrCloud

Testing performed
Tested changes locally and in environments

Additional context
Validated on K8s 1.15

@sepulworld
Copy link
Contributor Author

Perhaps before merging this, let me look into adding Pod resource options that can be passed to zk-operator and etcd-operator as well.

@HoustonPutman
Copy link
Contributor

I would probably change the name pod to solrPodPolicy, since we have been namespacing the solr properties with Solr. And there are other pods in the pipeline, such as the busybox pod, so it makes sense.

But this is definitely something I've been wanting to add myself, nice job!

let me look into adding Pod resource options that can be passed to zk-operator and etcd-operator as well

Let me know when you've made a decision on this front

…porter

Signed-off-by: Zane Williamson <zanew@zillow.com>
@sepulworld sepulworld force-pushed the feature/configurable_requests_and_limits branch from 6b07d13 to e281447 Compare October 31, 2019 01:39
@sepulworld
Copy link
Contributor Author

@HoustonPutman we should be good to go with this now. How does it look? Added etcd, zetcd and zookeeper pod policy (resources and affinity) options. Tested out all locally and works as expected! Let me know what you think. If we merge this, I can work with @swarupdonepudi to rebase his PR with my changes here.

Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments.

pkg/apis/solr/v1beta1/solrcloud_types.go Show resolved Hide resolved
pkg/apis/solr/v1beta1/solrcloud_types.go Show resolved Hide resolved
pkg/apis/solr/v1beta1/solrcloud_types.go Show resolved Hide resolved
pkg/apis/solr/v1beta1/solrprometheusexporter_types.go Outdated Show resolved Hide resolved
@sepulworld
Copy link
Contributor Author

Looks good, just a few comments.

Thank you! Updates pushed in

Signed-off-by: Zane Williamson <zanew@zillow.com>
@sepulworld sepulworld force-pushed the feature/configurable_requests_and_limits branch from 13a66ba to 29a9ae4 Compare October 31, 2019 21:57
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome work as always!

@HoustonPutman HoustonPutman merged commit 3e1d75f into apache:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants