-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding pod resources tuning options, adding imagepullsecert to promexporter #35
adding pod resources tuning options, adding imagepullsecert to promexporter #35
Conversation
Perhaps before merging this, let me look into adding Pod resource options that can be passed to zk-operator and etcd-operator as well. |
I would probably change the name But this is definitely something I've been wanting to add myself, nice job!
Let me know when you've made a decision on this front |
b7e735c
to
29ba990
Compare
…porter Signed-off-by: Zane Williamson <zanew@zillow.com>
6b07d13
to
e281447
Compare
@HoustonPutman we should be good to go with this now. How does it look? Added etcd, zetcd and zookeeper pod policy (resources and affinity) options. Tested out all locally and works as expected! Let me know what you think. If we merge this, I can work with @swarupdonepudi to rebase his PR with my changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments.
Thank you! Updates pushed in |
Signed-off-by: Zane Williamson <zanew@zillow.com>
13a66ba
to
29a9ae4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Awesome work as always!
Signed-off-by: Zane Williamson zanew@zillow.com
*Issue number of the reported bug or feature request: #34
Describe your changes
Added ImagePullSecrets and Pod Resource options to Deployment for PrometheusExporter
Added Pod Resource options to StatefulSet generation SolrCloud
Testing performed
Tested changes locally and in environments
Additional context
Validated on K8s 1.15