Adding a chRoot for provided zookeepers. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Houston Putman <hputman1@bloomberg.net>
Signed-off-by: Houston Putman <hputman1@bloomberg.net>
|
@sepulworld want to give this a shot? I'm not running a solr w/ a provided zookeeper right now, but I could spin one up with that if you don't have the time. |
|
Ill test it out! ty! |
sepulworld
reviewed
Jan 2, 2020
| #### v0.2.0 | ||
| - Uses `gomod` instead of `dep` | ||
| - `SolrCloud.zookeeperRef.provided.zookeeper.persistentVolumeClaimSpec` has been deprecated in favor of the `SolrCloud.zookeeperRef.provided.zookeeper.persistence` option. | ||
| This option is backwards compatible, but will be removed in a future version. | ||
| - An upgrade to the ZKOperator version `0.2.4` is required. |
There was a problem hiding this comment.
Good call, perhaps update https://github.com/bloomberg/solr-operator/blob/master/example/dependencies/operators.yaml#L50 to 0.2.4 as well?
There was a problem hiding this comment.
Good call for sure.
Signed-off-by: Houston Putman <hputman1@bloomberg.net>
Signed-off-by: Houston Putman <hputman1@bloomberg.net>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
|
Ok I think this is ready to go. I have tested it on my end with new chRoots for both external ZKs and provided ZKs. |
This is great! Thank you! |
|
Works well!
|
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Signed-off-by: Houston Putman <houstonputman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #61 *
Describe your changes
Added the possiblity to use chRoot for a provided zookeeper.
The zookeeperConnectionString for provided zookeepers was also changed to use the service name instead of the ip address. This should lower the number of restarts caused by service IP changes, if there were any in the first place.
Testing performed
Added tests around this functionality. Also added tests for other environment variables.