Rename operator downloads page to artifacts. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok confirmed locally that this works with the redirect that we have in place currently (and removing the extra htaccess file). Will go ahead and fix the solr-operator documentation to prepare for this change. |
uschindler
approved these changes
Aug 27, 2021
| @@ -71,7 +71,7 @@ RedirectMatch Permanent ^/docs/api-(.*) /docs/$1 | |||
|
|
|||
| ### Redirects to Apache Nightlies, this will change when they have a separate area for released artifacts | |||
| Redirect temp /charts https://nightlies.apache.org/solr/release/helm-charts | |||
| RewriteRule ^operator/downloads/?$ operator/downloads.html [PT] | |||
| Redirect temp /operator/downloads/crds https://nightlies.apache.org/solr/release/operator/crds | |||
There was a problem hiding this comment.
At a later stage, we can remove this line and add the "/operator/dowloads/crds" prefix to the regex for the Subversion rewrite.
There was a problem hiding this comment.
I would just need to modify the digits pattern for the version number a bit, but I will do this anyways.
There was a problem hiding this comment.
Yes that would be great.
|
So I actually like the new name of the page, since most people won't ever be "downloading" it really. I'll go ahead and commit this, and let you carry on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15593
This is done to simplify (and frankly fix) the current htaccess rules that the download page name makes necessary.
Will need to test this out locally and change the location in the Solr Operator documentation.