Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43895] Basic Repository Layout #3

Closed
wants to merge 14 commits into from

Conversation

grundprinzip
Copy link
Contributor

@grundprinzip grundprinzip commented May 31, 2023

Proposed Changes

In order to prepare the implementation of the Go client. This patch prepares the repository layout.

  • Adds the git submodule for the Spark repository, currently pointing at master for the reference to the proto files.
  • Adds the Makefile and the necessary outline for the build system
  • Adds the buf generation logic for the protos.

Testing

make gen && make check && make test

@zhengruifeng
Copy link

Is it possible to make apache/spark a submodule so that we don't need to copy the proto files?

@grundprinzip
Copy link
Contributor Author

Actually, I was looking at the submodule and found it too clunky, tried again and it's working quite nice, will change.

@grundprinzip
Copy link
Contributor Author

@zhengruifeng @HyukjinKwon this PR should be good now and the last PR before we can bring in the changes of Bo for the base client. The next step would be adding the workflow integration.

@HyukjinKwon HyukjinKwon changed the title [Spark 43895] Basic Repository Layout [SPARK-43895] Basic Repository Layout Jun 1, 2023
@@ -0,0 +1,105 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq, did you write this Makefile? or get it from somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this.

@HyukjinKwon
Copy link
Member

Merged to master.

@grundprinzip
Copy link
Contributor Author

Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants