Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43371] Minimize duplication across layers for chmod #37

Closed
wants to merge 1 commit into from

Conversation

Yikun
Copy link
Member

@Yikun Yikun commented May 6, 2023

What changes were proposed in this pull request?

This patch minimizes duplication across layers for chmod:

  • Move chmod g+w /opt/spark/work-dir to layer of /opt/spark/work-dir creation
  • Move chmod a+x /opt/decom.sh to layer of spark extration layer.
  • chmod a+x $VERSION/$TAG/entrypoint.sh when generate the entrypoint.sh
  • ./add-dockerfiles.sh 3.4.0 to apply changes

Why are the changes needed?

Address DOI review comments to minimize duplication across layers for chmod

To minimize duplication across layers, chmod's should be done in the layer that creates the file/folder (or in the case of a file from the context via COPY, it should have the +x committed to git)

docker-library/official-images#13089 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

@Yikun Yikun marked this pull request as ready for review May 6, 2023 02:26
@Yikun
Copy link
Member Author

Yikun commented May 6, 2023

cc @HyukjinKwon @zhengruifeng

@Yikun
Copy link
Member Author

Yikun commented May 6, 2023

@zhengruifeng Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants