[SPARK-44168] Add Apache Spark 3.4.1 Dockerfiles #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jun 25, 2023
|
@dongjoon-hyun Thanks, merged. |
|
Thank you! |
This was referenced Jun 25, 2023
Yikun
added a commit
that referenced
this pull request
Jun 29, 2023
### What changes were proposed in this pull request? Change GPG key from `34F0FC5C` to `F28C9C925C188C35E345614DEDA00CE834F0FC5C` to avoid pontential collision. The full finger print can get from below cmd: ``` $ wget https://dist.apache.org/repos/dist/dev/spark/KEYS $ gpg --import KEYS $ gpg --fingerprint 34F0FC5C pub rsa4096 2015-05-05 [SC] F28C 9C92 5C18 8C35 E345 614D EDA0 0CE8 34F0 FC5C uid [ unknown] Dongjoon Hyun (CODE SIGNING KEY) <dongjoonapache.org> sub rsa4096 2015-05-05 [E] ``` ### Why are the changes needed? - A short gpg key had been added as v3.4.0 gpg key in #46 . - The short key `34F0FC5C` is from https://dist.apache.org/repos/dist/dev/spark/KEYS - According DOI review comments, docker-library/official-images#13089 (comment) , `this should be the full key fingerprint: F28C9C925C188C35E345614DEDA00CE834F0FC5C (generating a collision for such a short key ID is trivial.` - We'd better to switch the short key to full fingerprint ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Closes #50 from Yikun/gpg_key. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Apache Spark 3.4.1 Dockerfiles.
Why are the changes needed?
Apache Spark 3.4.1 released:
https://spark.apache.org/releases/spark-release-3-4-1.html
Does this PR introduce any user-facing change?
Docker image will be published.
How was this patch tested?
Add workflow and CI passed