Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-44177] Add 'set -eo pipefail' to entrypoint and quote variables #49

Closed
wants to merge 1 commit into from

Conversation

Yikun
Copy link
Member

@Yikun Yikun commented Jun 25, 2023

What changes were proposed in this pull request?

Add 'set -eo pipefail' to entrypoint and quote variables

Why are the changes needed?

Address DOI comments:

  1. Have you considered a set -eo pipefail on the entrypoint script to help prevent any errors from being silently ignored?
  2. You probably want to quote this (and many of the other variables in this execution); ala --driver-url "$SPARK_DRIVER_URL"

[1] docker-library/official-images#13089 (comment)
[2] docker-library/official-images#13089 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

@Yikun Yikun changed the title Add 'set -eo pipefail' to entrypoint and quote variables [SPARK-44177] Add 'set -eo pipefail' to entrypoint and quote variables Jun 25, 2023
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun marked this pull request as ready for review June 26, 2023 09:05
@Yikun
Copy link
Member Author

Yikun commented Jun 26, 2023

cc @HyukjinKwon @zhengruifeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants