Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation.md #172

Closed
wants to merge 1 commit into from
Closed

Conversation

packtpartner
Copy link

Make sure that you generate site HTML with jekyll build, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain this PR?

@packtpartner
Copy link
Author

We have added a new book listing like the previous ones.

@felixcheung
Copy link
Member

tbh, we don't list every book though. but if you'd like, you will need to run the command in the PR description to re-generate the HTML, otherwise the book will not show up on the web page.

@srowen
Copy link
Member

srowen commented Jan 19, 2019

@packtpartner just run jekyll build and add the updated .html file to this PR.

@srowen
Copy link
Member

srowen commented Jan 31, 2019

Reopen if you update it

@srowen srowen closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants