Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spark v2.3.3 docs #181

Closed
wants to merge 1 commit into from
Closed

Conversation

maropu
Copy link
Member

@maropu maropu commented Feb 15, 2019

This PR aims to add the voted Apache Spark 2.3.3 docs directory. In a separate PR, I'll update the others (the links and announce and committer guide update items like https://checker.apache.org/projs/spark.html)

@maropu
Copy link
Member Author

maropu commented Feb 15, 2019

Could you check this, @srowen , @felixcheung?

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, it's so big it's almost not possible to review. The generated docs for 2.3.3 look sane. I couldn't get github to show me what changed outside of the site/docs/2.3.3 folder. Is there anything in this PR? or updating the site with news and download links separately?

@maropu
Copy link
Member Author

maropu commented Feb 15, 2019

Ya, you can find the other updates in #182.
Could you check there, too? Thanks!

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if everything is under site/docs/2.3.3

@felixcheung
Copy link
Member

right, it's better to separate PRs this way

@asfgit asfgit closed this in 1aff29e Feb 16, 2019
@maropu
Copy link
Member Author

maropu commented Feb 16, 2019

Thanks! Merged to asf-site.

@maropu maropu deleted the spark-2.3.3-docs branch February 16, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants