Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration pages (2.4.1/2.3.3/2.2.3) #192

Merged
merged 1 commit into from Apr 5, 2019

Conversation

dongjoon-hyun
Copy link
Member

The followings are the fixed screen shots.

2.4.1
Screen Shot 2019-04-05 at 9 32 22 AM

2.3.3
Screen Shot 2019-04-05 at 9 33 03 AM

2.2.3
Screen Shot 2019-04-05 at 9 33 19 AM

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Apr 5, 2019

I missed this at 2.2.3.
Could you review this, @dbtsai , @maropu , @srowen ?

@@ -134,10 +134,33 @@ <h1 class="title">Spark Configuration</h1>
<li><a href="#runtime-environment" id="markdown-toc-runtime-environment">Runtime Environment</a></li>
<li><a href="#shuffle-behavior" id="markdown-toc-shuffle-behavior">Shuffle Behavior</a></li>
<li><a href="#spark-ui" id="markdown-toc-spark-ui">Spark UI</a></li>
<li><a href="#compression-and-serialization" id="markdown-toc-compression-and-serialization">Compression and Serialization</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the 'hotfix' or new additional docs from later in the branch?
It's fine by me too, just checking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @srowen . It's the part of this hot fix. The broken tag makes the rest of doc is not generated correctly.

@dongjoon-hyun dongjoon-hyun merged commit 8555334 into apache:asf-site Apr 5, 2019
@dongjoon-hyun dongjoon-hyun deleted the fix_tag branch April 5, 2019 18:28
@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen .

@dbtsai
Copy link
Member

dbtsai commented Apr 6, 2019

Thank you @dongjoon-hyun to take care of it!

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a very big change?

@srowen
Copy link
Member

srowen commented Apr 6, 2019

See my comment and his answer above - this was in fact all 'corrections' of HTML that should have rendered but didn't.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Apr 6, 2019

Yep. To help the understanding,

  • I checked out the exact tag (v2.4.1, v2.3.3, v2.2.3) instead of the branches.
  • Generate the HTML and compare the result. At this time, all the same except the Google Analytics part in header.
  • Fix one line for the ending tag.
  • Generate the HTML again and compare the result. At this time, you can see this. I also preserve the Google Analytics header part, too.

Please follow the above procedure. You can get the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants