Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update committer page #281

Closed
wants to merge 2 commits into from
Closed

Update committer page #281

wants to merge 2 commits into from

Conversation

mridulm
Copy link

@mridulm mridulm commented Aug 3, 2020

I joined LinkedIn

@mridulm
Copy link
Author

mridulm commented Aug 3, 2020

@srowen I had removed local changes to site/developer-tools.html, site/examples.html, site/security.html, site/sitemap.xml made during to jekyl build before submitting pr - but looks like a merge will regenerate them ...
Is there a way to suppress this ?

Looks like version changes are triggering bunch of whitespace related mods - which will keep toggling based on which version everyone is on.

I am on 3.8.6 of jekyll (new box, so most deps are new from apt)

HyukjinKwon
HyukjinKwon approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Aug 3, 2020 •
edited

@mridulm, yeah they're some differences per the Jekyll version. I tried to make some fixes to minimise the diff before but not sure if we can have a great way to avoid them. I usually do the same thing as you did.

@asfgit asfgit closed this in 96a50b5 Aug 3, 2020
@srowen
Copy link
Member

srowen commented Aug 3, 2020

I'm on jekyll 4.1.0, and ideally, we'd use the latest one consistently. But yeah I usually revert any spurious changes and don't deal with it

@mridulm
Copy link
Author

mridulm commented Aug 3, 2020

Sounds good, thanks @HyukjinKwon, @srowen ! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

@gengliangwang gengliangwang gengliangwang approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mridulm @HyukjinKwon @srowen @gengliangwang