change the rule of resolved for Generate

apache · Apr 17, 2015 · 002c361 · 002c361
1 parent 04ae500
commit 002c361
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
@@ -495,7 +495,7 @@ class Analyzer(
         generatorOutput: Seq[Attribute]): Seq[Attribute] = {
       val elementTypes = generator.elementTypes
 
-      if (generatorOutput.size == elementTypes.size) {
+      if (generatorOutput.length == elementTypes.length) {
         generatorOutput.zip(elementTypes).map {
           case (a, (t, nullable)) if !a.resolved =>
             AttributeReference(a.name, t, nullable)()

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
@@ -112,8 +112,7 @@ case class Alias(child: Expression, name: String)(
   extends NamedExpression with trees.UnaryNode[Expression] {
 
   override type EvaluatedType = Any
-  // Alias(Generator, xx) need to be transformed into Generate(generator, ...)
-  override lazy val resolved = childrenResolved && !child.isInstanceOf[Generator]
+  override lazy val resolved = childrenResolved
 
   override def eval(input: Row): Any = child.eval(input)
 

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
@@ -61,6 +61,7 @@ case class Generate(
   override lazy val resolved: Boolean = {
     generator.resolved &&
       childrenResolved &&
+      generator.elementTypes.length == generatorOutput.length &&
       !generatorOutput.exists(!_.resolved)
   }