Comment / indenting cleanup.

apache · Jul 9, 2014 · 0093376 · 0093376
1 parent d81f998
commit 0093376
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala b/...lyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
@@ -69,13 +69,10 @@ abstract class CodeGenerator extends Logging {
    * @param objectTerm An possibly boxed version of the result of evaluating this expression.
    */
   protected case class EvaluatedExpression(
-                                            code: Seq[Tree],
-                                            nullTerm: TermName,
-                                            primitiveTerm: TermName,
-                                            objectTerm: TermName) {
-
-    def withObjectTerm = ???
-  }
+      code: Seq[Tree],
+      nullTerm: TermName,
+      primitiveTerm: TermName,
+      objectTerm: TermName)
 
   /**
    * Given an expression tree returns the code required to determine both if the result is NULL

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala
@@ -54,7 +54,7 @@ package object expressions  {
   abstract class MutableProjection extends Projection {
     def currentValue: Row
 
-    /* Updates the target of this projection to a new MutableRow */
+    /** Updates the target of this projection to a new MutableRow */
     def target(row: MutableRow): MutableProjection
   }
 }
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
@@ -72,6 +72,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
         }
         iteration += 1
         if (iteration > batch.strategy.maxIterations) {
+          // Only log if this is a rule that is supposed to run more than once.
           if (iteration != 2) {
             logger.info(s"Max iterations (${iteration - 1}) reached for batch ${batch.name}")
           }