Skip to content

Commit

Permalink
Revert "[SPARK-41537][INFRA][TESTS] Github Workflow Check for Breakin…
Browse files Browse the repository at this point in the history
…g Changes in Spark Connect Proto"

This reverts commit 280bc33.
  • Loading branch information
HyukjinKwon committed Mar 23, 2023
1 parent 280bc33 commit 04202b3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 111 deletions.
75 changes: 0 additions & 75 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ jobs:
\"java-11-17\": \"true\",
\"lint\" : \"true\",
\"k8s-integration-tests\" : \"true\",
\"proto-breaking-changes-check\" : \"true\",
}"
echo $precondition # For debugging
# Remove `\n` to avoid "Invalid format" error
Expand Down Expand Up @@ -494,80 +493,6 @@ jobs:
name: test-results-sparkr--8-${{ inputs.hadoop }}-hive2.3
path: "**/target/test-reports/*.xml"

proto-breaking-changes-check-master:
needs: [precondition]
if: always() && fromJson(needs.precondition.outputs.required).proto-breaking-changes-check == 'true'
name: Spark Connect proto backwards compatibility check (master)
continue-on-error: true
runs-on: ubuntu-22.04
env:
LC_ALL: C.UTF-8
LANG: C.UTF-8
PYSPARK_DRIVER_PYTHON: python3.9
PYSPARK_PYTHON: python3.9
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
with:
fetch-depth: 0
repository: apache/spark
ref: ${{ inputs.branch }}
- name: Add GITHUB_WORKSPACE to git trust safe.directory
run: |
git config --global --add safe.directory ${GITHUB_WORKSPACE}
- name: Sync the current branch with the latest in Apache Spark
if: github.repository != 'apache/spark'
run: |
git fetch https://github.com/$GITHUB_REPOSITORY.git ${GITHUB_REF#refs/heads/}
git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' merge --no-commit --progress --squash FETCH_HEAD
git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' commit -m "Merged commit" --allow-empty
# Install the `buf` CLI
- uses: bufbuild/buf-setup-action@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Run buf breaking.
- uses: bufbuild/buf-breaking-action@v1
with:
input: connector/connect/common/src/main
against: 'https://github.com/apache/spark.git#branch=master,subdir=connector/connect/common/src/main'

proto-breaking-changes-check-release:
needs: [precondition]
if: always() && fromJson(needs.precondition.outputs.required).proto-breaking-changes-check == 'true'
name: Spark Connect proto backwards compatibility check (master)
runs-on: ubuntu-22.04
env:
LC_ALL: C.UTF-8
LANG: C.UTF-8
PYSPARK_DRIVER_PYTHON: python3.9
PYSPARK_PYTHON: python3.9
steps:
- name: Checkout Spark repository
uses: actions/checkout@v3
with:
fetch-depth: 0
repository: apache/spark
ref: ${{ inputs.branch }}
- name: Add GITHUB_WORKSPACE to git trust safe.directory
run: |
git config --global --add safe.directory ${GITHUB_WORKSPACE}
- name: Sync the current branch with the latest in Apache Spark
if: github.repository != 'apache/spark'
run: |
git fetch https://github.com/$GITHUB_REPOSITORY.git ${GITHUB_REF#refs/heads/}
git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' merge --no-commit --progress --squash FETCH_HEAD
git -c user.name='Apache Spark Test Account' -c user.email='sparktestacc@gmail.com' commit -m "Merged commit" --allow-empty
# Install the `buf` CLI
- uses: bufbuild/buf-setup-action@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Run buf breaking.
- uses: bufbuild/buf-breaking-action@v1
with:
input: connector/connect/common/src/main
against: 'https://github.com/apache/spark.git#branch=branch-3.4,subdir=connector/connect/common/src/main'


# Static analysis, and documentation build
lint:
needs: [precondition, infra-image]
Expand Down
36 changes: 0 additions & 36 deletions dev/detect_breaking_changes.sh

This file was deleted.

0 comments on commit 04202b3

Please sign in to comment.