Use require to check for legitimate range

apache · Sep 11, 2015 · 0e86ae8 · 0e86ae8
1 parent 04aa45e
commit 0e86ae8
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala b/core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala
@@ -291,13 +291,8 @@ private[spark] class ExternalSorter[K, V, C](
       val it = collection.destructiveSortedWritablePartitionedIterator(comparator)
       while (it.hasNext) {
         val partitionId = it.nextPartition()
-        if (partitionId < 0) {
-          throw new IllegalArgumentException("Encountered negative partition Id: " + partitionId)
-        }
-        if (partitionId >= numPartitions) {
-          throw new IllegalArgumentException("Encountered partition Id: " + partitionId +
-            " which is >= " + numPartitions)
-        }
+        require(partitionId >= 0 && partitionId < numPartitions,
+          s"partition Id: ${partitionId} should be in the range (0, ${numPartitions})")
         it.writeNext(writer)
         elementsPerPartition(partitionId) += 1
         objectsWritten += 1