review

apache · Jun 12, 2020 · 1251b68 · 1251b68
1 parent 7850c2b
commit 1251b68
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
@@ -1342,7 +1342,7 @@ object PushPredicateThroughJoin extends Rule[LogicalPlan] with PredicateHelper {
             reduceLeftOption(And).map(Filter(_, newJoin)).getOrElse(newJoin)
 
         case jt =>
-          sys.error(s"Unexpected join type: $jt")
+          throw new IllegalStateException(s"Unexpected join type: $jt")
       }
 
     // push down the join filter into sub query scanning if applicable
@@ -1378,7 +1378,7 @@ object PushPredicateThroughJoin extends Rule[LogicalPlan] with PredicateHelper {
           Join(newLeft, newRight, joinType, newJoinCond, hint)
 
         case jt =>
-          sys.error(s"Unexpected join type: $jt")
+          throw new IllegalStateException(s"Unexpected join type: $jt")
       }
   }
 }

diff --git a/.../src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushCNFPredicateThroughJoin.scala b/.../src/main/scala/org/apache/spark/sql/catalyst/optimizer/PushCNFPredicateThroughJoin.scala
@@ -61,7 +61,7 @@ object PushCNFPredicateThroughJoin extends Rule[LogicalPlan] with PredicateHelpe
           case LeftOuter | LeftAnti | ExistenceJoin(_) =>
             Join(left, newRight, joinType, Some(joinCondition), hint)
           case jt =>
-            sys.error(s"Unexpected join type: $jt")
+            throw new IllegalStateException(s"Unexpected join type: $jt")
         }
       }
   }