Skip to content

Commit

Permalink
[SPARK-30489][BUILD] Make build delete pyspark.zip file properly
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

A small fix to the Maven build file under the `assembly` module by switch "dir" attribute to "file".

### Why are the changes needed?

To make the `<delete>` task properly delete an existing zip file.

### Does this PR introduce any user-facing change?

No

### How was this patch tested?

Ran a build with the change and confirmed that a corrupted zip file was replaced with the correct one.

Closes #27171 from jeff303/SPARK-30489.

Authored-by: Jeff Evans <jeffrey.wayne.evans@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 582509b)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
  • Loading branch information
jeff303 authored and dongjoon-hyun committed Jan 11, 2020
1 parent 0a5757e commit 3b029d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion assembly/pom.xml
Expand Up @@ -117,7 +117,7 @@
</executions>
<configuration>
<target>
<delete dir="${basedir}/../python/lib/pyspark.zip"/>
<delete file="${basedir}/../python/lib/pyspark.zip"/>
<zip destfile="${basedir}/../python/lib/pyspark.zip">
<fileset dir="${basedir}/../python/" includes="pyspark/**/*"/>
</zip>
Expand Down

0 comments on commit 3b029d9

Please sign in to comment.