add comments for the outermost quotes in windows launch scripts

apache · Oct 2, 2017 · 4795b0d · 4795b0d
1 parent 26fc756
commit 4795b0d
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 0 deletions.
diff --git a/bin/beeline.cmd b/bin/beeline.cmd
@@ -17,4 +17,6 @@ rem See the License for the specific language governing permissions and
 rem limitations under the License.
 rem
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0spark-class.cmd" org.apache.hive.beeline.BeeLine %*"
diff --git a/bin/pyspark.cmd b/bin/pyspark.cmd
@@ -20,4 +20,6 @@ rem
 rem This is the entry point for running PySpark. To avoid polluting the
 rem environment, it just launches a new cmd to do the real work.
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0pyspark2.cmd" %*"
diff --git a/bin/run-example.cmd b/bin/run-example.cmd
@@ -19,4 +19,7 @@ rem
 
 set SPARK_HOME=%~dp0..
 set _SPARK_CMD_USAGE=Usage: ./bin/run-example [options] example-class [example args]
+
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0spark-submit.cmd" run-example %*"
diff --git a/bin/spark-class.cmd b/bin/spark-class.cmd
@@ -20,4 +20,6 @@ rem
 rem This is the entry point for running a Spark class. To avoid polluting
 rem the environment, it just launches a new cmd to do the real work.
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0spark-class2.cmd" %*"
diff --git a/bin/spark-shell.cmd b/bin/spark-shell.cmd
@@ -20,4 +20,6 @@ rem
 rem This is the entry point for running Spark shell. To avoid polluting the
 rem environment, it just launches a new cmd to do the real work.
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0spark-shell2.cmd" %*"
diff --git a/bin/spark-submit.cmd b/bin/spark-submit.cmd
@@ -20,4 +20,6 @@ rem
 rem This is the entry point for running Spark submit. To avoid polluting the
 rem environment, it just launches a new cmd to do the real work.
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0spark-submit2.cmd" %*"
diff --git a/bin/sparkR.cmd b/bin/sparkR.cmd
@@ -20,4 +20,6 @@ rem
 rem This is the entry point for running SparkR. To avoid polluting the
 rem environment, it just launches a new cmd to do the real work.
 
+rem The outermost quotes are used to prevent Windows command line parse error
+rem when there are some quotes in parameters, see SPARK-21877.
 cmd /V /E /C ""%~dp0sparkR2.cmd" %*"