Skip to content

Commit

Permalink
style fix
Browse files Browse the repository at this point in the history
  • Loading branch information
yjshen committed Jul 14, 2015
1 parent 653d047 commit 7e163ae
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
package org.apache.spark.sql.catalyst.util

trait BigDecimalConverter[T] {
def toBigDecimal(in: T) : BigDecimal
def fromBigDecimal(bd: BigDecimal) : T
def toBigDecimal(in: T): BigDecimal
def fromBigDecimal(bd: BigDecimal): T
}

/**
Expand All @@ -29,32 +29,32 @@ trait BigDecimalConverter[T] {
object BigDecimalConverter {

implicit object ByteConverter extends BigDecimalConverter[Byte] {
def toBigDecimal(in: Byte) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toByte
def toBigDecimal(in: Byte): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Byte = bd.toByte
}

implicit object ShortConverter extends BigDecimalConverter[Short] {
def toBigDecimal(in: Short) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toShort
def toBigDecimal(in: Short): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Short = bd.toShort
}

implicit object IntConverter extends BigDecimalConverter[Int] {
def toBigDecimal(in: Int) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toInt
def toBigDecimal(in: Int): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Int = bd.toInt
}

implicit object LongConverter extends BigDecimalConverter[Long] {
def toBigDecimal(in: Long) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toLong
def toBigDecimal(in: Long): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Long = bd.toLong
}

implicit object FloatConverter extends BigDecimalConverter[Float] {
def toBigDecimal(in: Float) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toFloat
def toBigDecimal(in: Float): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Float = bd.toFloat
}

implicit object DoubleConverter extends BigDecimalConverter[Double] {
def toBigDecimal(in: Double) = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal) = bd.toDouble
def toBigDecimal(in: Double): BigDecimal = BigDecimal(in)
def fromBigDecimal(bd: BigDecimal): Double = bd.toDouble
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ class ExpressionTypeCheckingSuite extends SparkFunSuite {

test("check types for ROUND") {
assertError(Round(Seq()), "ROUND require one or two arguments")
assertError(Round(Seq(Literal(null),'booleanField)),
assertError(Round(Seq(Literal(null), 'booleanField)),
"Only Integral Literal or Null Literal are allowed for ROUND scale argument")
assertError(Round(Seq(Literal(null), 'complexField)),
"Only Integral Literal or Null Literal are allowed for ROUND scale argument")
Expand Down

0 comments on commit 7e163ae

Please sign in to comment.